shirshanka commented on a change in pull request #2609: GOBBLIN-744: Support
cancellation of a Helix workflow via a DELETE Spec.
URL: https://github.com/apache/incubator-gobblin/pull/2609#discussion_r277403888
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SleepingTask.java
##########
@@ -17,24 +17,51 @@
package org.apache.gobblin.cluster;
+import java.io.IOException;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+
import avro.shaded.com.google.common.base.Throwables;
import lombok.extern.slf4j.Slf4j;
import org.apache.gobblin.runtime.TaskContext;
+import org.apache.gobblin.runtime.TaskState;
import org.apache.gobblin.runtime.task.BaseAbstractTask;
@Slf4j
public class SleepingTask extends BaseAbstractTask {
+ public static final String TASK_STATE_FILE_KEY = "task.state.file.path";
+
private final long sleepTime;
+ private FileSystem fs;
Review comment:
Do you need Hadoop FileSystem here? If you use java filesystem, you can set
it to delete on process shutdown to ensure cleanup happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
