shirshanka commented on a change in pull request #2609: GOBBLIN-744: Support
cancellation of a Helix workflow via a DELETE Spec.
URL: https://github.com/apache/incubator-gobblin/pull/2609#discussion_r277741264
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FsSpecConsumer.java
##########
@@ -74,6 +78,8 @@ public FsSpecConsumer(Config config) {
return null;
}
+ Arrays.sort(fileStatuses,
Comparator.comparingLong(FileStatus::getModificationTime));
Review comment:
add a comment for why you're doing it and what you're expecting (ascending
sort?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
