sv2000 commented on a change in pull request #2674: [GOBBLIN-808] implement
azkaban flow cancel when dag manager is enabled
URL: https://github.com/apache/incubator-gobblin/pull/2674#discussion_r301880633
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlanListSerializer.java
##########
@@ -83,6 +83,14 @@ public JsonElement serialize(List<JobExecutionPlan> src,
Type typeOfSrc, JsonSer
String executionStatus = jobExecutionPlan.getExecutionStatus().name();
jobExecutionPlanJson.addProperty(SerializationConstants.EXECUTION_STATUS_KEY,
executionStatus);
+ try {
+ String jobExecutionFuture =
jobExecutionPlan.getSpecExecutor().getProducer().get()
+
.serializeAddSpecResponse(jobExecutionPlan.getJobFuture().orNull());
+
jobExecutionPlanJson.addProperty(SerializationConstants.JOB_EXECUTION_FUTURE,
jobExecutionFuture);
+ } catch (InterruptedException | ExecutionException e) {
+ log.warn("Error during serialization of JobExecutionFuture.");
Review comment:
I think I had a comment earlier about this. Not sure, if it got lost. But
should we propagate the exception? It may not be much use persisting a dag
which cannot be deserialized back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
