sv2000 commented on a change in pull request #2674: [GOBBLIN-808] implement
azkaban flow cancel when dag manager is enabled
URL: https://github.com/apache/incubator-gobblin/pull/2674#discussion_r301880891
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlanListDeserializer.java
##########
@@ -107,6 +110,16 @@ public JobExecutionPlanListDeserializer(Map<URI,
TopologySpec> topologySpecMap)
JobExecutionPlan jobExecutionPlan = new JobExecutionPlan(jobSpec,
specExecutor);
jobExecutionPlan.setExecutionStatus(executionStatus);
+
+ try {
+ String jobExecutionFuture =
serializedJobExecutionPlan.get(SerializationConstants.JOB_EXECUTION_FUTURE).getAsString();
+ Future future =
specExecutor.getProducer().get().deserializeAddSpecResponse(jobExecutionFuture);
+ jobExecutionPlan.setJobFuture(Optional.fromNullable(future));
+
+ } catch (ExecutionException | InterruptedException e) {
Review comment:
Maybe propagate the exception - instead of silently logging and returning?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
