[
https://issues.apache.org/jira/browse/GOBBLIN-861?focusedWorklogId=295980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295980
]
ASF GitHub Bot logged work on GOBBLIN-861:
------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Aug/19 02:46
Start Date: 16/Aug/19 02:46
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2716:
[GOBBLIN-861]Skip getPartition() call to Hive Metastore when a partition
already e…
URL: https://github.com/apache/incubator-gobblin/pull/2716#discussion_r314567012
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##########
@@ -501,8 +482,30 @@ private void addOrAlterPartition(IMetaStoreClient client,
Table table, HiveParti
}
}
}
+ protected void OnPartitionExist(IMetaStoreClient client, Table table,
HivePartition partition, Partition nativePartition, TException e) throws
TException {
Review comment:
Why not make `addOrAlterPartition` protected and overwrite that ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 295980)
Time Spent: 50m (was: 40m)
> Skip getPartition() call to Hive Metastore when a partition already exists
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-861
> URL: https://issues.apache.org/jira/browse/GOBBLIN-861
> Project: Apache Gobblin
> Issue Type: Task
> Components: hive-registration
> Reporter: Zihan Li
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently, we compute a diff between the current partition and an already
> registered partition when a partition has already been registered in Hive.
> This is done by calling getPartition() on the Hive metastore client, which
> can be expensive. Since no time-varying attributes are stored in a Hive
> partition, diff computation (and getPartition() call) can be skipped when a
> partition already exists.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
