[ 
https://issues.apache.org/jira/browse/GOBBLIN-861?focusedWorklogId=296512&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296512
 ]

ASF GitHub Bot logged work on GOBBLIN-861:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Aug/19 19:14
            Start Date: 16/Aug/19 19:14
    Worklog Time Spent: 10m 
      Work Description: codecov-io commented on issue #2716: [GOBBLIN-861]Skip 
getPartition() call to Hive Metastore when a partition already e…
URL: 
https://github.com/apache/incubator-gobblin/pull/2716#issuecomment-522121077
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2716?src=pr&el=h1)
 Report
   > Merging 
[#2716](https://codecov.io/gh/apache/incubator-gobblin/pull/2716?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/c7e4a6efbb08c433c2be69958eebae3b328e347a?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2716/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2716?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2716      +/-   ##
   ============================================
   + Coverage     45.07%   45.07%   +<.01%     
   - Complexity     8738     8743       +5     
   ============================================
     Files          1879     1880       +1     
     Lines         70162    70186      +24     
     Branches       7704     7707       +3     
   ============================================
   + Hits          31625    31636      +11     
   - Misses        35617    35626       +9     
   - Partials       2920     2924       +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2716?src=pr&el=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2716/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2716/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
 | `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
   | 
[...e/gobblin/config/store/zip/ZipFileConfigStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2716/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbmZpZy9zdG9yZS96aXAvWmlwRmlsZUNvbmZpZ1N0b3JlLmphdmE=)
 | `73.21% <0%> (-1.34%)` | `12% <0%> (ø)` | |
   | 
[...apache/gobblin/hive/avro/HiveAvroSerDeManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2716/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL2F2cm8vSGl2ZUF2cm9TZXJEZU1hbmFnZXIuamF2YQ==)
 | `52.17% <0%> (-0.77%)` | `8% <0%> (ø)` | |
   | 
[...g/apache/gobblin/metrics/event/EventSubmitter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2716/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9ldmVudC9FdmVudFN1Ym1pdHRlci5qYXZh)
 | `37.03% <0%> (-0.7%)` | `3% <0%> (ø)` | |
   | 
[...che/gobblin/hive/metastore/HiveMetaStoreUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2716/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlVXRpbHMuamF2YQ==)
 | `31.83% <0%> (-0.15%)` | `12% <0%> (ø)` | |
   | 
[...onfig/store/api/PhysicalPathNotExistException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2716/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbmZpZy9zdG9yZS9hcGkvUGh5c2ljYWxQYXRoTm90RXhpc3RFeGNlcHRpb24uamF2YQ==)
 | `0% <0%> (ø)` | `0% <0%> (?)` | |
   | 
[.../org/apache/gobblin/hive/HiveRegistrationUnit.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2716/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL0hpdmVSZWdpc3RyYXRpb25Vbml0LmphdmE=)
 | `47.39% <0%> (+0.37%)` | `33% <0%> (+1%)` | :arrow_up: |
   | 
[...urce/extractor/extract/kafka/ConfigStoreUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2716/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9Db25maWdTdG9yZVV0aWxzLmphdmE=)
 | `60% <0%> (+0.42%)` | `18% <0%> (+1%)` | :arrow_up: |
   | 
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2716/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
 | `39.25% <0%> (+6.54%)` | `13% <0%> (+2%)` | :arrow_up: |
   | ... and [1 
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2716/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2716?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2716?src=pr&el=footer).
 Last update 
[c7e4a6e...6b63812](https://codecov.io/gh/apache/incubator-gobblin/pull/2716?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 296512)
    Time Spent: 2h  (was: 1h 50m)

> Skip getPartition() call to Hive Metastore when a partition already exists
> --------------------------------------------------------------------------
>
>                 Key: GOBBLIN-861
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-861
>             Project: Apache Gobblin
>          Issue Type: Task
>          Components: hive-registration
>            Reporter: Zihan Li
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Currently, we compute a diff between the current partition and an already 
> registered partition when a partition has already been registered in Hive. 
> This is done by calling getPartition() on the Hive metastore client, which 
> can be expensive. Since no time-varying attributes are stored in a Hive 
> partition, diff computation (and getPartition() call) can be skipped when a 
> partition already exists.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to