[ 
https://issues.apache.org/jira/browse/GOBBLIN-861?focusedWorklogId=295979&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295979
 ]

ASF GitHub Bot logged work on GOBBLIN-861:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Aug/19 02:46
            Start Date: 16/Aug/19 02:46
    Worklog Time Spent: 10m 
      Work Description: autumnust commented on pull request #2716: 
[GOBBLIN-861]Skip getPartition() call to Hive Metastore when a partition 
already e…
URL: https://github.com/apache/incubator-gobblin/pull/2716#discussion_r314566577
 
 

 ##########
 File path: 
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreRegisterWithoutComputingPartitionDiff.java
 ##########
 @@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.hive.metastore;
+
+import com.google.common.base.Optional;
+import java.io.IOException;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.gobblin.configuration.State;
+import org.apache.gobblin.hive.HivePartition;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.AlreadyExistsException;
+import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.apache.thrift.TException;
+
+
+@Slf4j
+public class HiveMetaStoreRegisterWithoutComputingPartitionDiff extends 
HiveMetaStoreBasedRegister {
+  public HiveMetaStoreRegisterWithoutComputingPartitionDiff(State state, 
Optional<String> metastoreURI) throws IOException {
+    super(state, metastoreURI);
+  }
+
+  @Override
+  protected void OnPartitionExist(IMetaStoreClient client, Table table, 
HivePartition partition,
+      Partition nativePartition, TException e) throws TException {
+    if(e instanceof AlreadyExistsException) {
 
 Review comment:
   nit-pick: pay attention to blank between character and bracket
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 295979)
    Time Spent: 40m  (was: 0.5h)

> Skip getPartition() call to Hive Metastore when a partition already exists
> --------------------------------------------------------------------------
>
>                 Key: GOBBLIN-861
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-861
>             Project: Apache Gobblin
>          Issue Type: Task
>          Components: hive-registration
>            Reporter: Zihan Li
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently, we compute a diff between the current partition and an already 
> registered partition when a partition has already been registered in Hive. 
> This is done by calling getPartition() on the Hive metastore client, which 
> can be expensive. Since no time-varying attributes are stored in a Hive 
> partition, diff computation (and getPartition() call) can be skipped when a 
> partition already exists.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to