shirshanka commented on a change in pull request #2721: Add offset look-back option in Kafka consumer URL: https://github.com/apache/incubator-gobblin/pull/2721#discussion_r317370398
########## File path: gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaSource.java ########## @@ -90,6 +90,8 @@ public static final String LATEST_OFFSET = "latest"; public static final String EARLIEST_OFFSET = "earliest"; public static final String NEAREST_OFFSET = "nearest"; + public static final String OFFSET_LOOKBACK = "offset_lookback"; + public static final String TIMESTAMP_LOOKBACK = "timestamp_lookback"; Review comment: seems like timestamp lookback is not being used. Do you plan to modify this PR with support for timestamp lookback as well? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
