shirshanka commented on a change in pull request #2721: Add offset look-back
option in Kafka consumer
URL: https://github.com/apache/incubator-gobblin/pull/2721#discussion_r317370314
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaSource.java
##########
@@ -451,7 +459,21 @@ private WorkUnit
getWorkUnitForTopicPartition(KafkaPartition partition, SourceSt
LOG.warn(
offsetNotFoundMsg + "This partition will start from the earliest
offset: " + offsets.getEarliestOffset());
offsets.startAtEarliestOffset();
- } else {
+ } else if (offsetOption.equals(OFFSET_LOOKBACK)) {
+ long lookbackOffsetRange =
state.getPropAsLong("kafka.offset.lookback", 0L);
Review comment:
refactor to static constant "kafka.offset.lookback"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
