shirshanka commented on a change in pull request #2721: Add offset look-back
option in Kafka consumer
URL: https://github.com/apache/incubator-gobblin/pull/2721#discussion_r317422041
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaSource.java
##########
@@ -451,7 +459,43 @@ private WorkUnit
getWorkUnitForTopicPartition(KafkaPartition partition, SourceSt
LOG.warn(
offsetNotFoundMsg + "This partition will start from the earliest
offset: " + offsets.getEarliestOffset());
offsets.startAtEarliestOffset();
- } else {
+ } else if (offsetOption.equals(OFFSET_LOOKBACK)) {
+ long lookbackOffsetRange = state.getPropAsLong(KAFKA_OFFSET_LOOKBACK ,
0L);
+ long offset = offsets.getLatestOffset() - lookbackOffsetRange;
+ LOG.warn(offsetNotFoundMsg + "This partition will start from
latest-lookback [ " + offsets.getLatestOffset() + " - " + lookbackOffsetRange +
" ] start offset: " + offset);
Review comment:
You could have an incorrect log line due to a race condition:
offsets.getLatestOffset() here could be different from the result on line 464.
I'd suggest caching the value in a variable (on line 464) and using it in
subsequent code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
