[
https://issues.apache.org/jira/browse/GOBBLIN-863?focusedWorklogId=302332&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302332
]
ASF GitHub Bot logged work on GOBBLIN-863:
------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/19 19:26
Start Date: 27/Aug/19 19:26
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on pull request #2719:
[GOBBLIN-863]Handle race condition issue for hive registration
URL: https://github.com/apache/incubator-gobblin/pull/2719#discussion_r318255786
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##########
@@ -197,6 +211,18 @@ private boolean
ensureHiveTableExistenceBeforeAlternation(String tableName, Stri
try (Timer.Context context =
this.metricContext.timer(GET_HIVE_TABLE).time()) {
existingTable =
HiveMetaStoreUtils.getHiveTable(client.getTable(dbName, tableName));
}
+ //TODO: Determine whether we still use inline hive registration,
+ // if so, instead of fetching schema from schema registry, we need to
enable schema version
+ if (this.schemaRegistry.isPresent()) {
Review comment:
This is the previous way we plan to solve the race condition. But I realize
this is not the final schema which writer use. So I will implement schema
version instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 302332)
Time Spent: 1h 50m (was: 1h 40m)
> Handle race condition between concurrent Gobblin tasks performing Hive
> registration
> -----------------------------------------------------------------------------------
>
> Key: GOBBLIN-863
> URL: https://issues.apache.org/jira/browse/GOBBLIN-863
> Project: Apache Gobblin
> Issue Type: Task
> Components: hive-registration
> Reporter: Zihan Li
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
