[
https://issues.apache.org/jira/browse/GOBBLIN-863?focusedWorklogId=302370&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302370
]
ASF GitHub Bot logged work on GOBBLIN-863:
------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/19 20:34
Start Date: 27/Aug/19 20:34
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2719:
[GOBBLIN-863]Handle race condition issue for hive registration
URL: https://github.com/apache/incubator-gobblin/pull/2719#discussion_r318284064
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/HiveLock.java
##########
@@ -37,30 +39,45 @@
* </p>
*/
public class HiveLock {
+ private static String HIVE_LOCK_TYPE =
HiveMetaStoreBasedRegister.HIVE_REGISTER_METRICS_PREFIX + "lock.type";
+ private static String HIVE_LOCK_TYPE_DEFAULT =
"org.apache.gobblin.hive.HiveLockFactory";
- private static final Joiner JOINER = Joiner.on(' ').skipNulls();
+ private Properties properties;
- private final Striped<Lock> locks = Striped.lazyWeakLock(Integer.MAX_VALUE);
+ private static final Joiner JOINER = Joiner.on('/').skipNulls();
Review comment:
I see, makes sense if under ZK's context. Then it might be better make it
implementation-specific, but I don't have strong opinion onit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 302370)
Time Spent: 2h 10m (was: 2h)
> Handle race condition between concurrent Gobblin tasks performing Hive
> registration
> -----------------------------------------------------------------------------------
>
> Key: GOBBLIN-863
> URL: https://issues.apache.org/jira/browse/GOBBLIN-863
> Project: Apache Gobblin
> Issue Type: Task
> Components: hive-registration
> Reporter: Zihan Li
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
