[
https://issues.apache.org/jira/browse/GOBBLIN-863?focusedWorklogId=303077&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-303077
]
ASF GitHub Bot logged work on GOBBLIN-863:
------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Aug/19 18:20
Start Date: 28/Aug/19 18:20
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2719:
[GOBBLIN-863]Handle race condition issue for hive registration
URL: https://github.com/apache/incubator-gobblin/pull/2719#discussion_r318725463
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/locks/DistributedHiveLockFactory.java
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.runtime.locks;
+
+import java.io.IOException;
+import java.util.Properties;
+import org.apache.gobblin.hive.HiveLockFactory;
+import org.apache.gobblin.hive.HiveLockImpl;
+
+/**
+ * A lock factory that extends {@link HiveLockFactory} provide a get method
for a distributed lock for a specific object
+ */
+public class DistributedHiveLockFactory extends HiveLockFactory {
+ public DistributedHiveLockFactory(Properties properties) {
+ super(properties);
+ }
+ public HiveLockImpl get(String name) {
+ return new HiveLockImpl<ZookeeperBasedJobLock>(new
ZookeeperBasedJobLock(properties, name)) {
+ @Override
+ public void lock() throws IOException {
+ try {
+ this.lock.lock();
+ } catch (Exception e) {
+ throw new IOException(e);
+ }
+ }
+
+ @Override
+ public void unlock() throws IOException {
+ try {
+ this.lock.unlock();
+ } catch (Exception e) {
Review comment:
Why this exception needs to be caught and throw again? And why the exception
handling between Distributed lock need be different from local lock ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 303077)
Time Spent: 2h 50m (was: 2h 40m)
> Handle race condition between concurrent Gobblin tasks performing Hive
> registration
> -----------------------------------------------------------------------------------
>
> Key: GOBBLIN-863
> URL: https://issues.apache.org/jira/browse/GOBBLIN-863
> Project: Apache Gobblin
> Issue Type: Task
> Components: hive-registration
> Reporter: Zihan Li
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
