sv2000 commented on a change in pull request #2633: GOBBLIN-759: Added feature to support DistCP to copy files that were … URL: https://github.com/apache/incubator-gobblin/pull/2633#discussion_r324483538
########## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/ModifiedDateRangeBasedFileFilter.java ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gobblin.data.management.copy; + +import java.util.Collection; +import java.util.Iterator; +import java.util.Properties; + +import lombok.extern.slf4j.Slf4j; + +import org.apache.hadoop.fs.FileSystem; +import org.joda.time.DateTime; +import org.joda.time.DateTimeZone; +import org.joda.time.Period; +import org.joda.time.format.PeriodFormatter; +import org.joda.time.format.PeriodFormatterBuilder; + +import com.google.common.collect.ImmutableList; + +import org.apache.gobblin.configuration.ConfigurationKeys; + + +/** + * A {@link CopyableFileFilter} that drops a {@link CopyableFile} if file modified time not between the loop back window + * <code>sourceFs<code> + */ +@Slf4j +public class ModifiedDateRangeBasedFileFilter implements CopyableFileFilter { Review comment: Looks like most of the logic inside this class can be moved to a parent class that implements a "DateRangeFileFilter". ModTimeDateRangeFileFilter can extend this class and pass modification time to filter files. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
