arekusuri commented on a change in pull request #2722: GOBBLIN-865: Add feature
that enables PK-chunking in partition
URL: https://github.com/apache/incubator-gobblin/pull/2722#discussion_r327243183
##########
File path:
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceExtractor.java
##########
@@ -857,7 +850,7 @@ public SalesforceBulkJobId
getQueryResultIdsPkChunking(String entity, List<Predi
BatchInfo bulkBatchInfo =
this.bulkConnection.createBatchFromStream(this.bulkJob, bout);
- long expectedSizePerBatch = usingPkChunking ? this.pkChunkingSize :
this.getExpectedRecordCount();
+ long expectedSizePerBatch = this.getExpectedRecordCount();
Review comment:
My original approach was - change this function as less as possible. But you
asked to remove a lot useless code, my understanding was to clean up the
pk-chunking logic from this function.
I removed the field `this.usingPkChunking` so we have to remove this part.
It won't break anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
