[ https://issues.apache.org/jira/browse/GOBBLIN-822?focusedWorklogId=319828&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319828 ]
ASF GitHub Bot logged work on GOBBLIN-822: ------------------------------------------ Author: ASF GitHub Bot Created on: 27/Sep/19 21:03 Start Date: 27/Sep/19 21:03 Worklog Time Spent: 10m Work Description: sv2000 commented on pull request #2685: [GOBBLIN-822] Upgrade log4j to log4j2 for LogRouting use-case URL: https://github.com/apache/incubator-gobblin/pull/2685#discussion_r329249421 ########## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/task/HiveConverterUtils.java ########## @@ -435,7 +435,7 @@ public static String updatePartitionLocation(String outputDataPartitionLocation, table = Optional.of(client.get().getTable(dbName, tableName)); if (table.isPresent()) { org.apache.hadoop.hive.ql.metadata.Table qlTable = new org.apache.hadoop.hive.ql.metadata.Table(table.get()); - if (HiveUtils.isPartitioned(qlTable)) { + if (qlTable.isPartitioned()) { Review comment: We can change this as part of separate PR if not related to log4j2 change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 319828) > upgrade log4j to log4j2 > ----------------------- > > Key: GOBBLIN-822 > URL: https://issues.apache.org/jira/browse/GOBBLIN-822 > Project: Apache Gobblin > Issue Type: Sub-task > Affects Versions: 0.14.0 > Reporter: Jay Sen > Priority: Major > Fix For: 0.15.0 > > Time Spent: 3h > Remaining Estimate: 0h > > log4j2 has routing appender that would be super useful and probably only way > to achieve " job specific log files" functionality without meddling around > fileHandler in log4j. > Also log4j2 has lot of new functionalities and performance benefits (ref: > HIVE-11304) -- This message was sent by Atlassian Jira (v8.3.4#803005)