[
https://issues.apache.org/jira/browse/GOBBLIN-822?focusedWorklogId=319850&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319850
]
ASF GitHub Bot logged work on GOBBLIN-822:
------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/19 21:47
Start Date: 27/Sep/19 21:47
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2685: [GOBBLIN-822]
Upgrade log4j to log4j2 for LogRouting use-case
URL:
https://github.com/apache/incubator-gobblin/pull/2685#issuecomment-521050459
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2685?src=pr&el=h1)
Report
> Merging
[#2685](https://codecov.io/gh/apache/incubator-gobblin/pull/2685?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/b9bcfa0100b13dc02dbb2c3d2e62fb536be6959c?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2685 +/- ##
============================================
- Coverage 45.19% 45.19% -0.01%
Complexity 8804 8804
============================================
Files 1889 1889
Lines 70579 70577 -2
Branches 7747 7746 -1
============================================
- Hits 31900 31899 -1
Misses 35725 35725
+ Partials 2954 2953 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2685?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...e/gobblin/data/management/copy/hive/HiveUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2685/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlVXRpbHMuamF2YQ==)
| `21.95% <ø> (-2.44%)` | `3 <0> (-1)` | |
|
[...bblin/data/management/trash/TrashCollectorJob.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2685/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9kYXRhL21hbmFnZW1lbnQvdHJhc2gvVHJhc2hDb2xsZWN0b3JKb2IuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...rsion/finder/AbstractHiveDatasetVersionFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2685/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3ZlcnNpb24vZmluZGVyL0Fic3RyYWN0SGl2ZURhdGFzZXRWZXJzaW9uRmluZGVyLmphdmE=)
| `50% <0%> (ø)` | `3 <0> (ø)` | :arrow_down: |
|
[...ement/conversion/hive/task/HiveConverterUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2685/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS90YXNrL0hpdmVDb252ZXJ0ZXJVdGlscy5qYXZh)
| `56.25% <0%> (ø)` | `23 <0> (ø)` | :arrow_down: |
|
[...g/apache/gobblin/azkaban/AzkabanGobblinDaemon.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2685/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Hb2JibGluRGFlbW9uLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...ment/conversion/hive/validation/ValidationJob.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2685/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9kYXRhL21hbmFnZW1lbnQvY29udmVyc2lvbi9oaXZlL3ZhbGlkYXRpb24vVmFsaWRhdGlvbkpvYi5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...ava/org/apache/gobblin/util/hadoop/TokenUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2685/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvaGFkb29wL1Rva2VuVXRpbHMuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...org/apache/gobblin/config/client/ConfigClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2685/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlnL2NsaWVudC9Db25maWdDbGllbnQuamF2YQ==)
| `44.64% <100%> (ø)` | `15 <1> (ø)` | :arrow_down: |
|
[.../management/conversion/hive/source/HiveSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2685/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9zb3VyY2UvSGl2ZVNvdXJjZS5qYXZh)
| `65.71% <100%> (+0.17%)` | `24 <0> (ø)` | :arrow_down: |
|
[...blin/config/client/ConfigStoreFactoryRegister.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2685/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlnL2NsaWVudC9Db25maWdTdG9yZUZhY3RvcnlSZWdpc3Rlci5qYXZh)
| `7.69% <100%> (ø)` | `1 <1> (ø)` | :arrow_down: |
| ... and [12
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2685/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2685?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2685?src=pr&el=footer).
Last update
[b9bcfa0...dada7a4](https://codecov.io/gh/apache/incubator-gobblin/pull/2685?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 319850)
Time Spent: 3.5h (was: 3h 20m)
> upgrade log4j to log4j2
> -----------------------
>
> Key: GOBBLIN-822
> URL: https://issues.apache.org/jira/browse/GOBBLIN-822
> Project: Apache Gobblin
> Issue Type: Sub-task
> Affects Versions: 0.14.0
> Reporter: Jay Sen
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> log4j2 has routing appender that would be super useful and probably only way
> to achieve " job specific log files" functionality without meddling around
> fileHandler in log4j.
> Also log4j2 has lot of new functionalities and performance benefits (ref:
> HIVE-11304)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
