[
https://issues.apache.org/jira/browse/GOBBLIN-954?focusedWorklogId=340855&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340855
]
ASF GitHub Bot logged work on GOBBLIN-954:
------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/19 01:29
Start Date: 09/Nov/19 01:29
Worklog Time Spent: 10m
Work Description: vikrambohra commented on pull request #2803:
[GOBBLIN-954] Added support to swap different HiveRegistrationPublishers
URL: https://github.com/apache/incubator-gobblin/pull/2803
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-954] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-954
### Description
- [x ] Here are some details about my PR, including screenshots (if
applicable):
1. Added logic to support swapping of different implementations of
HiveRegistrationPublisher in HiveRegTaskStateCollectorServiceHandlerImpl
2. Added "data.publisher.latest.file.arrival.timestamp" as current time in
millis whenever a task finishes
### Tests
- [ x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Code already covered by test cases TaskStateCollectorServiceTest
### Commits
- [ x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 340855)
Remaining Estimate: 0h
Time Spent: 10m
> Added logic to support swapping of different implementations of
> HiveRegistrationPublisher
> -----------------------------------------------------------------------------------------
>
> Key: GOBBLIN-954
> URL: https://issues.apache.org/jira/browse/GOBBLIN-954
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> - logic to support swapping of different implementations of
> HiveRegistrationPublisher in HiveRegTaskStateCollectorServiceHandlerImpl
> - Added "data.publisher.latest.file.arrival.timestamp" as current time in
> millis whenever a tasj finishes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
