[
https://issues.apache.org/jira/browse/GOBBLIN-954?focusedWorklogId=341371&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341371
]
ASF GitHub Bot logged work on GOBBLIN-954:
------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/19 16:43
Start Date: 11/Nov/19 16:43
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2803:
[GOBBLIN-954] Added support to swap different HiveRegistrationPublishers
URL: https://github.com/apache/incubator-gobblin/pull/2803#discussion_r344802143
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/HiveRegTaskStateCollectorServiceHandlerImpl.java
##########
@@ -38,17 +37,19 @@
@Slf4j
public class HiveRegTaskStateCollectorServiceHandlerImpl implements
TaskStateCollectorServiceHandler {
+ private static final String HIVE_REG_PUBLISHER_CLASS =
"hive.reg.publisher.class";
Review comment:
This naming is ambiguous, better to equip it with some information about
task-collection-service
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 341371)
Time Spent: 1h 40m (was: 1.5h)
> Added logic to support swapping of different implementations of
> HiveRegistrationPublisher
> -----------------------------------------------------------------------------------------
>
> Key: GOBBLIN-954
> URL: https://issues.apache.org/jira/browse/GOBBLIN-954
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> - logic to support swapping of different implementations of
> HiveRegistrationPublisher in HiveRegTaskStateCollectorServiceHandlerImpl
> - Added "data.publisher.latest.file.arrival.timestamp" as current time in
> millis whenever a task finishes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
