[
https://issues.apache.org/jira/browse/GOBBLIN-954?focusedWorklogId=340869&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340869
]
ASF GitHub Bot logged work on GOBBLIN-954:
------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/19 02:25
Start Date: 09/Nov/19 02:25
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2803:
[GOBBLIN-954] Added support to swap different HiveRegistrationPublishers
URL: https://github.com/apache/incubator-gobblin/pull/2803#discussion_r344424313
##########
File path:
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
##########
@@ -874,6 +890,9 @@
* Hive registration properties
*/
public static final String HIVE_REGISTRATION_POLICY =
"hive.registration.policy";
+ public static final String HIVE_REG_PUBLISHER_CLASS =
"hive.reg.publisher.class";
Review comment:
I actually believe we should stop adding configurations into this
`ConfigurationKey` class but put all these configurations into most relevant
class. The reason is if you put everything here and make them public static
final, any constructs within Gobblin that carrying state can modify it without
any restriction, and also you lost context on what does this configuration
really mean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 340869)
Time Spent: 20m (was: 10m)
> Added logic to support swapping of different implementations of
> HiveRegistrationPublisher
> -----------------------------------------------------------------------------------------
>
> Key: GOBBLIN-954
> URL: https://issues.apache.org/jira/browse/GOBBLIN-954
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> - logic to support swapping of different implementations of
> HiveRegistrationPublisher in HiveRegTaskStateCollectorServiceHandlerImpl
> - Added "data.publisher.latest.file.arrival.timestamp" as current time in
> millis whenever a tasj finishes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
