[
https://issues.apache.org/jira/browse/GOBBLIN-954?focusedWorklogId=341396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341396
]
ASF GitHub Bot logged work on GOBBLIN-954:
------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/19 18:01
Start Date: 11/Nov/19 18:01
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2803: [GOBBLIN-954]
Added support to swap different HiveRegistrationPublishers
URL:
https://github.com/apache/incubator-gobblin/pull/2803#issuecomment-552291899
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2803?src=pr&el=h1)
Report
> Merging
[#2803](https://codecov.io/gh/apache/incubator-gobblin/pull/2803?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/4efc5fb6d8f16b56e8fc1858c8093a150353a348?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `11.42%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2803?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2803 +/- ##
============================================
- Coverage 45.47% 45.47% -0.01%
+ Complexity 8899 8897 -2
============================================
Files 1897 1897
Lines 71016 71026 +10
Branches 7817 7817
============================================
+ Hits 32298 32301 +3
- Misses 35742 35748 +6
- Partials 2976 2977 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2803?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2803/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...e/gobblin/publisher/HiveRegistrationPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2803/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9IaXZlUmVnaXN0cmF0aW9uUHVibGlzaGVyLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...rg/apache/gobblin/publisher/BaseDataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2803/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9CYXNlRGF0YVB1Ymxpc2hlci5qYXZh)
| `68.05% <0%> (-0.22%)` | `62 <0> (ø)` | |
|
[...ain/java/org/apache/gobblin/hive/HiveRegister.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2803/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL0hpdmVSZWdpc3Rlci5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...e/HiveRegTaskStateCollectorServiceHandlerImpl.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2803/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvSGl2ZVJlZ1Rhc2tTdGF0ZUNvbGxlY3RvclNlcnZpY2VIYW5kbGVySW1wbC5qYXZh)
| `69.23% <66.66%> (-5.77%)` | `3 <0> (ø)` | |
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2803/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2803/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0%> (-7.15%)` | `3% <0%> (-1%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2803/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `64.81% <0%> (-0.47%)` | `28% <0%> (ø)` | |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2803/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2803/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2803?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2803?src=pr&el=footer).
Last update
[4efc5fb...bb11b47](https://codecov.io/gh/apache/incubator-gobblin/pull/2803?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 341396)
Time Spent: 1h 50m (was: 1h 40m)
> Added logic to support swapping of different implementations of
> HiveRegistrationPublisher
> -----------------------------------------------------------------------------------------
>
> Key: GOBBLIN-954
> URL: https://issues.apache.org/jira/browse/GOBBLIN-954
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> - logic to support swapping of different implementations of
> HiveRegistrationPublisher in HiveRegTaskStateCollectorServiceHandlerImpl
> - Added "data.publisher.latest.file.arrival.timestamp" as current time in
> millis whenever a task finishes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
