[
https://issues.apache.org/jira/browse/GOBBLIN-1042?focusedWorklogId=383232&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383232
]
ASF GitHub Bot logged work on GOBBLIN-1042:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/20 22:58
Start Date: 06/Feb/20 22:58
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2882: [GOBBLIN-1042] Fix
ForkMetric incorrect return type of parent metric object and relevant unit
tests
URL:
https://github.com/apache/incubator-gobblin/pull/2882#issuecomment-583152328
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=h1)
Report
> Merging
[#2882](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/ef3003c85531aaeacb760a4e30fca2d3069001aa?src=pr&el=desc)
will **decrease** coverage by `41.64%`.
> The diff coverage is `18.51%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2882 +/- ##
============================================
- Coverage 45.73% 4.09% -41.65%
+ Complexity 9112 747 -8365
============================================
Files 1921 1924 +3
Lines 72391 72424 +33
Branches 7967 7967
============================================
- Hits 33106 2963 -30143
- Misses 36262 69143 +32881
+ Partials 3023 318 -2705
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...apache/gobblin/metrics/GobblinMetricsRegistry.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvR29iYmxpbk1ldHJpY3NSZWdpc3RyeS5qYXZh)
| `0% <ø> (-27.59%)` | `0 <0> (-6)` | |
|
[...ache/gobblin/cluster/InMemorySingleTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSW5NZW1vcnlTaW5nbGVUYXNrUnVubmVyLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...g/apache/gobblin/cluster/InMemoryWuSingleTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSW5NZW1vcnlXdVNpbmdsZVRhc2suamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...a/org/apache/gobblin/cluster/SingleTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlVGFza1J1bm5lci5qYXZh)
| `0% <0%> (-1.86%)` | `0 <0> (-1)` | |
|
[...ava/org/apache/gobblin/metrics/GobblinMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvR29iYmxpbk1ldHJpY3MuamF2YQ==)
| `0% <0%> (-18.87%)` | `0 <0> (-15)` | |
|
[...he/gobblin/cluster/InMemoryWuFailedSingleTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSW5NZW1vcnlXdUZhaWxlZFNpbmdsZVRhc2suamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...in/java/org/apache/gobblin/cluster/SingleTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlVGFzay5qYXZh)
| `0% <0%> (-81.14%)` | `0 <0> (-9)` | |
|
[...a/org/apache/gobblin/cluster/ContainerMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvQ29udGFpbmVyTWV0cmljcy5qYXZh)
| `0% <0%> (-100%)` | `0 <0> (-4)` | |
|
[...a/org/apache/gobblin/runtime/util/ForkMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9Gb3JrTWV0cmljcy5qYXZh)
| `100% <100%> (ø)` | `5 <2> (-1)` | :arrow_down: |
|
[...a/org/apache/gobblin/runtime/util/TaskMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9UYXNrTWV0cmljcy5qYXZh)
| `81.25% <100%> (ø)` | `8 <1> (ø)` | :arrow_down: |
| ... and [1121
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=footer).
Last update
[ef3003c...c6e60b3](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 383232)
Time Spent: 20m (was: 10m)
> ForkMetrics generates parent metric object with incorrect type
> --------------------------------------------------------------
>
> Key: GOBBLIN-1042
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1042
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
