[
https://issues.apache.org/jira/browse/GOBBLIN-1042?focusedWorklogId=386333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386333
]
ASF GitHub Bot logged work on GOBBLIN-1042:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Feb/20 01:07
Start Date: 13/Feb/20 01:07
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2882:
[GOBBLIN-1042] Fix ForkMetric incorrect return type of parent metric object and
relevant unit tests
URL: https://github.com/apache/incubator-gobblin/pull/2882#discussion_r378601088
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/InMemoryWuSingleTask.java
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.cluster;
+
+import java.io.IOException;
+import java.util.List;
+
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.runtime.JobState;
+import org.apache.gobblin.runtime.util.StateStores;
+import org.apache.gobblin.source.workunit.WorkUnit;
+import org.apache.gobblin.writer.DataWriter;
+import org.apache.gobblin.writer.DataWriterBuilder;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+
+import com.google.common.collect.Lists;
+import com.typesafe.config.Config;
+
+/**
+ * Instead of deserializing {@link JobState} and {@link WorkUnit} from
filesystem, create them in memory.
+ * Uses {@link DummyDataWriter} so that the execution of a Task goes through.
+ */
+public class InMemoryWuSingleTask extends InMemoryWuFailedSingleTask {
Review comment:
SGTM. Addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 386333)
Time Spent: 1h 10m (was: 1h)
> ForkMetrics generates parent metric object with incorrect type
> --------------------------------------------------------------
>
> Key: GOBBLIN-1042
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1042
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
