[ https://issues.apache.org/jira/browse/GOBBLIN-1042?focusedWorklogId=383234&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383234 ]
ASF GitHub Bot logged work on GOBBLIN-1042: ------------------------------------------- Author: ASF GitHub Bot Created on: 06/Feb/20 23:01 Start Date: 06/Feb/20 23:01 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2882: [GOBBLIN-1042] Fix ForkMetric incorrect return type of parent metric object and relevant unit tests URL: https://github.com/apache/incubator-gobblin/pull/2882#issuecomment-583152328 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=h1) Report > Merging [#2882](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/ef3003c85531aaeacb760a4e30fca2d3069001aa?src=pr&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `18.51%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #2882 +/- ## ============================================ + Coverage 45.73% 45.81% +0.08% - Complexity 9112 9130 +18 ============================================ Files 1921 1924 +3 Lines 72391 72424 +33 Branches 7967 7967 ============================================ + Hits 33106 33182 +76 + Misses 36262 36220 -42 + Partials 3023 3022 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...apache/gobblin/metrics/GobblinMetricsRegistry.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvR29iYmxpbk1ldHJpY3NSZWdpc3RyeS5qYXZh) | `27.58% <ø> (ø)` | `6 <0> (ø)` | :arrow_down: | | [...ache/gobblin/cluster/InMemorySingleTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSW5NZW1vcnlTaW5nbGVUYXNrUnVubmVyLmphdmE=) | `100% <0%> (ø)` | `3 <0> (?)` | | | [...g/apache/gobblin/cluster/InMemoryWuSingleTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSW5NZW1vcnlXdVNpbmdsZVRhc2suamF2YQ==) | `100% <0%> (ø)` | `2 <0> (?)` | | | [...a/org/apache/gobblin/cluster/SingleTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlVGFza1J1bm5lci5qYXZh) | `87.71% <0%> (+85.86%)` | `11 <0> (+10)` | :arrow_up: | | [...ava/org/apache/gobblin/metrics/GobblinMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvR29iYmxpbk1ldHJpY3MuamF2YQ==) | `18.8% <0%> (-0.06%)` | `15 <0> (ø)` | | | [...he/gobblin/cluster/InMemoryWuFailedSingleTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSW5NZW1vcnlXdUZhaWxlZFNpbmdsZVRhc2suamF2YQ==) | `100% <0%> (ø)` | `3 <0> (?)` | | | [...in/java/org/apache/gobblin/cluster/SingleTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlVGFzay5qYXZh) | `81.48% <0%> (+0.34%)` | `9 <0> (ø)` | :arrow_down: | | [...a/org/apache/gobblin/cluster/ContainerMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvQ29udGFpbmVyTWV0cmljcy5qYXZh) | `100% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: | | [...a/org/apache/gobblin/runtime/util/ForkMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9Gb3JrTWV0cmljcy5qYXZh) | `100% <100%> (ø)` | `5 <2> (-1)` | :arrow_down: | | [...a/org/apache/gobblin/runtime/util/TaskMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9UYXNrTWV0cmljcy5qYXZh) | `81.25% <100%> (ø)` | `8 <1> (ø)` | :arrow_down: | | ... and [1121 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2882/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=footer). Last update [ef3003c...c6e60b3](https://codecov.io/gh/apache/incubator-gobblin/pull/2882?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 383234) Time Spent: 0.5h (was: 20m) > ForkMetrics generates parent metric object with incorrect type > -------------------------------------------------------------- > > Key: GOBBLIN-1042 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1042 > Project: Apache Gobblin > Issue Type: Improvement > Reporter: Lei Sun > Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)