autumnust opened a new pull request #2912: [GOBBLIN-1072] Add sliding window to protect AutoScaling from fluctuation of number of active Helix partitions URL: https://github.com/apache/incubator-gobblin/pull/2912 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - https://issues.apache.org/jira/browse/GOBBLIN-1072 ### Description - An additional data structure `MaxValueEvictingQueue` to wrap multiple instances of `numTargetContainers` and behaved like an sliding-window where we could fetch the maxValue in the sliding-window in constant time. - The advantage of this data structure is, if there's fluctuation in the number of active Helix partitions, a single fluctuation wont't impact the number of containers we requested in `YarnService`. - The sliding-window's size is defined by the number of attempts that we query Helix for getting partitions number. ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how"
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
