sv2000 commented on a change in pull request #2912: [GOBBLIN-1072] Being more conservative on leasing containers URL: https://github.com/apache/incubator-gobblin/pull/2912#discussion_r389192007
########## File path: gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java ########## @@ -71,6 +74,8 @@ private final String WINDOW_SIZE_OBSERVING_CONTAINER_REQUEST = AUTO_SCALING_PREFIX + "windowSize"; + private final static int DEFAULT_MAX_IDLE_TIME_BEFORE_SCALING_DOWN_MIN = 10; Review comment: MIN -> MINUTES? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
