sv2000 commented on a change in pull request #2912: [GOBBLIN-1072] Being more
conservative on leasing containers
URL: https://github.com/apache/incubator-gobblin/pull/2912#discussion_r389193932
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java
##########
@@ -149,6 +173,17 @@ public void run() {
}
}
+ /**
+ * Getting all instances (Helix Participants) in cluster at this moment.
+ * Note that the raw result could contains AppMaster node and replanner
node.
+ * @param filterString Helix instances whose name containing fitlerString
will pass filtering.
+ */
+ private Set<String> getParticipants(String filterString) {
+ PropertyKey.Builder keyBuilder = helixDataAccessor.keyBuilder();
+ return helixDataAccessor.getChildValuesMap(keyBuilder.instances())
Review comment:
Would it suffice to get keyBuilder.liveInstances() instead of instances()
which may return instances from previous runs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
