[ https://issues.apache.org/jira/browse/GOBBLIN-1105?focusedWorklogId=413533&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413533 ]
ASF GitHub Bot logged work on GOBBLIN-1105: ------------------------------------------- Author: ASF GitHub Bot Created on: 31/Mar/20 21:34 Start Date: 31/Mar/20 21:34 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2945: [GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore URL: https://github.com/apache/incubator-gobblin/pull/2945#issuecomment-606889224 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=h1) Report > Merging [#2945](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/7b9c7cbbff76c6963576846b81bfdae8ced4ba22&el=desc) will **decrease** coverage by `0.96%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #2945 +/- ## ============================================ - Coverage 45.58% 44.62% -0.97% + Complexity 9160 8985 -175 ============================================ Files 1936 1936 Lines 73292 73302 +10 Branches 8088 8089 +1 ============================================ - Hits 33413 32713 -700 - Misses 36784 37538 +754 + Partials 3095 3051 -44 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/gobblin/metastore/DatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0RhdGFzZXRTdGF0ZVN0b3JlLmphdmE=) | `4.34% <ø> (+4.34%)` | `1.00 <0.00> (+1.00)` | | | [.../apache/gobblin/metastore/DatasetStoreDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0RhdGFzZXRTdG9yZURhdGFzZXQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...he/gobblin/metastore/MysqlJobStatusStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsSm9iU3RhdHVzU3RhdGVTdG9yZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...lin/metastore/MysqlJobStatusStateStoreFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsSm9iU3RhdHVzU3RhdGVTdG9yZUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | | | [...gobblin/metastore/MysqlStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...askStateCollectorServiceHiveRegHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlQ29sbGVjdG9yU2VydmljZUhpdmVSZWdIYW5kbGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...re/filesystem/FsDatasetStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0YXN0b3JlL2ZpbGVzeXN0ZW0vRnNEYXRhc2V0U3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...in/runtime/mapreduce/CustomizedProgresserBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0N1c3RvbWl6ZWRQcm9ncmVzc2VyQmFzZS5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [49 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=footer). Last update [7b9c7cb...62c0251](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 413533) Time Spent: 20m (was: 10m) > make MysqlJobStatusStateStore implements DatasetStateStore > ---------------------------------------------------------- > > Key: GOBBLIN-1105 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1105 > Project: Apache Gobblin > Issue Type: Improvement > Reporter: Arjun Singh Bora > Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > make MysqlJobStatusStateStore implements DatasetStateStore so that we can use > existing cleaners/dataset finders/version finders to clean job status -- This message was sent by Atlassian Jira (v8.3.4#803005)