[
https://issues.apache.org/jira/browse/GOBBLIN-1105?focusedWorklogId=413607&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413607
]
ASF GitHub Bot logged work on GOBBLIN-1105:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/20 23:11
Start Date: 31/Mar/20 23:11
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2945: [GOBBLIN-1105]
some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore
URL: https://github.com/apache/incubator-gobblin/pull/2945#discussion_r401267437
##########
File path:
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/MysqlStateStore.java
##########
@@ -73,7 +74,7 @@
*
* @param <T> state object type
**/
-public class MysqlStateStore<T extends State> implements StateStore<T> {
+public class MysqlStateStore<T extends State> implements StateStore<T>,
DatasetStateStore<T> {
Review comment:
This is looking strange. The child class MySqlDatasetStateStore extends
MySqlStateStore and implements DatasetStateStore. And the parent class is
implementing the interface. See my comment earlier about considering the
possibility of MysqlJobStatusStore extending MySqlDatasetStateStore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 413607)
Time Spent: 40m (was: 0.5h)
> make MysqlJobStatusStateStore implements DatasetStateStore
> ----------------------------------------------------------
>
> Key: GOBBLIN-1105
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1105
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> make MysqlJobStatusStateStore implements DatasetStateStore so that we can use
> existing cleaners/dataset finders/version finders to clean job status
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
