sv2000 commented on a change in pull request #2945: [GOBBLIN-1105] some
refactoring and make MysqlJobStatusStateStore implements DatasetStateStore
URL: https://github.com/apache/incubator-gobblin/pull/2945#discussion_r403242940
##########
File path:
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/MysqlJobStatusStateStore.java
##########
@@ -50,12 +61,63 @@ public MysqlJobStatusStateStore(DataSource dataSource,
String stateStoreTableNam
/**
* Returns all the job statuses for a flow group, flow name, flow execution
id
- * @param storeName
- * @param flowExecutionId
- * @return
- * @throws IOException
+ * @param storeName store name in the state store
+ * @param flowExecutionId Flow Execution Id
+ * @return list of states
+ * @throws IOException in case of failures
*/
public List<T> getAll(String storeName, long flowExecutionId) throws
IOException {
return getAll(storeName, flowExecutionId + "%", true);
}
+
+ @Override
+ public List<DatasetStateStoreEntryManager<T>>
getMetadataForTables(StateStorePredicate predicate)
Review comment:
Ok. Resolving this comment, since this class needs metrics emission from
other methods as well. Makes sense to create a separate PR for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
