codecov-io edited a comment on issue #2945: [GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore URL: https://github.com/apache/incubator-gobblin/pull/2945#issuecomment-606889224 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=h1) Report > Merging [#2945](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/d54e66b857a34e871fd7c9ab28e37c9c9f061432&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #2945 +/- ## ============================================ - Coverage 45.58% 45.56% -0.02% - Complexity 9157 9160 +3 ============================================ Files 1936 1937 +1 Lines 73286 73322 +36 Branches 8088 8092 +4 ============================================ + Hits 33409 33412 +3 - Misses 36782 36814 +32 - Partials 3095 3096 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...a/org/apache/gobblin/cluster/HelixJobsMapping.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhKb2JzTWFwcGluZy5qYXZh) | `89.58% <0.00%> (+6.89%)` | `13.00 <0.00> (ø)` | | | [.../apache/gobblin/metastore/DatasetStoreDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0RhdGFzZXRTdG9yZURhdGFzZXQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...he/gobblin/metastore/MysqlJobStatusStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsSm9iU3RhdHVzU3RhdGVTdG9yZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...etastore/MysqlJobStatusStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsSm9iU3RhdHVzU3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lin/metastore/MysqlJobStatusStateStoreFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsSm9iU3RhdHVzU3RhdGVTdG9yZUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `8.19% <ø> (ø)` | `2.00 <0.00> (ø)` | | | [...ache/gobblin/metastore/MysqlStateStoreFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...astore/metadata/DatasetStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL21ldGFkYXRhL0RhdGFzZXRTdGF0ZVN0b3JlRW50cnlNYW5hZ2VyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [.../apache/gobblin/metastore/ZkStateStoreFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL1prU3RhdGVTdG9yZUZhY3RvcnkuamF2YQ==) | `71.42% <ø> (ø)` | `2.00 <0.00> (ø)` | | | [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0.00%> (-7.15%)` | `3.00% <0.00%> (ø%)` | | | ... and [7 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2945/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=footer). Last update [d54e66b...f325b74](https://codecov.io/gh/apache/incubator-gobblin/pull/2945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services