[
https://issues.apache.org/jira/browse/GOBBLIN-1154?focusedWorklogId=436600&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-436600
]
ASF GitHub Bot logged work on GOBBLIN-1154:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/20 17:22
Start Date: 22/May/20 17:22
Worklog Time Spent: 10m
Work Description: aplex commented on a change in pull request #2993:
URL: https://github.com/apache/incubator-gobblin/pull/2993#discussion_r429366904
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java
##########
@@ -81,7 +83,7 @@ public CreateKVResponse createFlowConfig(FlowConfig
flowConfig, boolean triggerL
} else if
(Boolean.parseBoolean(responseMap.getOrDefault(ServiceConfigKeys.COMPILATION_SUCCESSFUL,
new AddSpecResponse<>("false")).getValue().toString())) {
httpStatus = HttpStatus.S_201_CREATED;
} else {
- httpStatus = HttpStatus.S_400_BAD_REQUEST;
+ throw new RestLiServiceException(HttpStatus.S_400_BAD_REQUEST, "Flow was
not compiled successfully");
Review comment:
So this will be primarily used by SREs? I can think of a situation when
they have a 2-page flow and a typo in it. How would they find where the typo
is? Are there any helpful compilation exceptions we can provide? For example:
"problem is in the line 123, variable 'sssschema' is not found", or "no path
found between 'faro' and 'warr', check the names of the source and the target").
If we can't pinpoint a single error and the problems are all around, we can
send users to the compilation logs, and provide them some unique token so that
they can find the relevant lines easily. For example: "for more information,
check the GaaS logs that have requestId=XXX"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 436600)
Time Spent: 2h (was: 1h 50m)
> Improve gaas error messages
> ---------------------------
>
> Key: GOBBLIN-1154
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1154
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
