[ https://issues.apache.org/jira/browse/GOBBLIN-1154?focusedWorklogId=437527&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437527 ]
ASF GitHub Bot logged work on GOBBLIN-1154: ------------------------------------------- Author: ASF GitHub Bot Created on: 27/May/20 04:02 Start Date: 27/May/20 04:02 Worklog Time Spent: 10m Work Description: aplex commented on a change in pull request #2993: URL: https://github.com/apache/incubator-gobblin/pull/2993#discussion_r430721098 ########## File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java ########## @@ -81,7 +83,7 @@ public CreateKVResponse createFlowConfig(FlowConfig flowConfig, boolean triggerL } else if (Boolean.parseBoolean(responseMap.getOrDefault(ServiceConfigKeys.COMPILATION_SUCCESSFUL, new AddSpecResponse<>("false")).getValue().toString())) { httpStatus = HttpStatus.S_201_CREATED; } else { - httpStatus = HttpStatus.S_400_BAD_REQUEST; + throw new RestLiServiceException(HttpStatus.S_400_BAD_REQUEST, "Flow was not compiled successfully"); Review comment: That can be a good start. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 437527) Time Spent: 2h 10m (was: 2h) > Improve gaas error messages > --------------------------- > > Key: GOBBLIN-1154 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1154 > Project: Apache Gobblin > Issue Type: Improvement > Reporter: Jack Moseley > Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)