[
https://issues.apache.org/jira/browse/GORA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417763#comment-13417763
]
Ferdy Galema commented on GORA-94:
----------------------------------
Hi,
Thanks for the elaborate explanation. This is great stuff. I quickly glanced at
some changes and notes a few things.
In HBaseStore, you start iterating from 1 to fields.size(). I think this should
be 0.
About the dirty fields: Does a getMap() and changing some stuff without calling
setMap(..) make that map field dirty? (I ask because I see the various
putToMap(..) methods are now missing. Currently structural changes to maps are
not tracked if I am not mistaken, unless they are done using the putToMap(..)
methods).
Is compatibility an issue here? In the sense that after applying this fix it
will change how final serialization is done?
One final question. What is the easiest way to make a unified diff of all the
relevant changes in your git branch, so that I can apply it easily on svn
branches. That way I can test it extensively by running my some integration
tests.
> Upgrade to Apache Avro 1.7.x
> ----------------------------
>
> Key: GORA-94
> URL: https://issues.apache.org/jira/browse/GORA-94
> Project: Apache Gora
> Issue Type: Sub-task
> Components: build process, storage
> Affects Versions: 0.2
> Reporter: Lewis John McGibbney
> Assignee: Ed Kohlwey
> Fix For: 0.3
>
> Attachments: GORA-94-v2.patch, GORA-94.patch
>
>
> I am not sure what this involves as of yet but I have a small feeling that
> it's going to be some reasonably major work...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
