[ 
https://issues.apache.org/jira/browse/GORA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418159#comment-13418159
 ] 

Ferdy Galema commented on GORA-94:
----------------------------------

Ok.

About the CharSequence and ByteBuffer types: Is it possible to make them 
immutable? Perhaps by overriding the mutators and throw exceptions. I already 
noticed that you are returning CharSequence (which has no mutator methods in 
the interface), instead of Utf8. Is this not a hint to the user that it should 
not be casting/changing the value? ByteBuffer can already be read-only. This 
might change client usage (only if a client was directly changing the mutable 
in the first place), but perhaps this is worth the change. Anyway we can always 
try to solve this problem later and leave the semantics as they currently are.

I think it is no problem that the format of intermediate output is changed. If 
there is the case that the final input/output rows have changed then this is 
something we just have to find out. It might depend on the store. I will test 
this with the HBaseStore.

Thanks for the git info. I will manage to create diffs for me. However if you a 
have final version to be tested I think it's best to upload a patch yourself.
                
> Upgrade to Apache Avro 1.7.x
> ----------------------------
>
>                 Key: GORA-94
>                 URL: https://issues.apache.org/jira/browse/GORA-94
>             Project: Apache Gora
>          Issue Type: Sub-task
>          Components: build process, storage
>    Affects Versions: 0.2
>            Reporter: Lewis John McGibbney
>            Assignee: Ed Kohlwey
>             Fix For: 0.3
>
>         Attachments: GORA-94-v2.patch, GORA-94.patch
>
>
> I am not sure what this involves as of yet but I have a small feeling that 
> it's going to be some reasonably major work...  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to