After messing around with this version a bit I think the only two unit tests 
that fail are testUpdate() and testDeleteByQueryFields(). The commitWithin 
parameter on commits seems to want to be set to 0 for the quick round-trip 
tests we're doing. I'm not sure if there'll be a benefit for huge batches, so 
it's probably safer to leave this as a configurable property and default to 0.

That testUpdate test has me pretty confused. It seems 
webPage.getOutlinks().clear() doesn't clear out the map, so later when it 
checks that count equals webPage.getOutlinks().size() it's finding more than it 
expects. Any idea what could cause Map.clear() not to work? Maybe a reference 
to an item is still in scope?


-Scott


On Jun 24, 2013, at 7:20 AM, Scott Stults (JIRA) <[email protected]> wrote:

> 
>     [ 
> https://issues.apache.org/jira/browse/GORA-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>  ]
> 
> Scott Stults updated GORA-9:
> ----------------------------
> 
>    Attachment: GORA-9-v6.patch
> 
> Sorry about the test errors -- there are definitely some gaps in 
> functionality. I saw how some other modules are deferring those by overriding 
> the test methods, so I am too :)
> 
> This latest version implements the NRT search stuff in the latest Solr, with 
> the exception of deletes -- those are still doing hard commits afterward. 
> Maybe after some testing we should switch those over as well.
> 
>> Implement a Solr-based store
>> ----------------------------
>> 
>>                Key: GORA-9
>>                URL: https://issues.apache.org/jira/browse/GORA-9
>>            Project: Apache Gora
>>         Issue Type: New Feature
>>         Components: gora-solr, storage
>>           Reporter: Andrzej Bialecki 
>>           Assignee: Andrzej Bialecki 
>>            Fix For: 0.4
>> 
>>        Attachments: GORA-9.patch, GORA-9.patch, GORA-9-v3.patch, 
>> GORA-9-v4.patch, GORA-9-v5.patch, GORA-9-v5.patch, GORA-9-v6.patch, 
>> org.apache.gora.solr.store.TestSolrStore.txt
>> 
>> 
>> For applications that use Solr it may be convenient to store data in a 
>> dedicated Solr core. SolrJ API provides necessary support to implement a 
>> DataStore.
> 
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to