[ https://issues.apache.org/jira/browse/GOSSIP-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973947#comment-15973947 ]
ASF GitHub Bot commented on GOSSIP-79: -------------------------------------- Github user edwardcapriolo commented on a diff in the pull request: https://github.com/apache/incubator-gossip/pull/47#discussion_r112104363 --- Diff: gossip-base/src/main/java/org/apache/gossip/transport/TransportManager.java --- @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gossip.transport; + +import java.io.IOException; +import java.net.URI; + +/** interface for manage that sends and receives messages that have already been serialized. */ +public interface TransportManager { + void startActiveGossiper(); --- End diff -- Add some comments here as to why there is two start methods. Do they need to be called in order why have two and not one . etc. > create gossip-transport-udp module > ---------------------------------- > > Key: GOSSIP-79 > URL: https://issues.apache.org/jira/browse/GOSSIP-79 > Project: Gossip > Issue Type: Improvement > Reporter: Gary Dusbabek > Assignee: Gary Dusbabek > > Create a transport module that houses the UDP transport. > This will probably require some refactoring. It may be prudent to create a > few interfaces that are kept in gossip-core which are then implemented in > gossip-transport-udp. > This probably needs to be a modules > 1 udp-server > 2 udp-client > OtherThings: > GossipManager.build() needs to look at the URI and dynamically load the right > server > GossipCore.send() needs to locate the right client for a URI. > Both of these things probably need a registry. Please dont make it a static > singleton thing ! :) -- This message was sent by Atlassian JIRA (v6.3.15#6346)