[ https://issues.apache.org/jira/browse/GOSSIP-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974617#comment-15974617 ]
ASF GitHub Bot commented on GOSSIP-79: -------------------------------------- Github user gdusbabek commented on a diff in the pull request: https://github.com/apache/incubator-gossip/pull/47#discussion_r112197675 --- Diff: gossip-base/src/main/java/org/apache/gossip/manager/GossipManager.java --- @@ -46,14 +48,21 @@ public abstract class GossipManager { public static final Logger LOGGER = Logger.getLogger(GossipManager.class); + + // this mapper is used for ring and user-data persistence only. NOT messages. + public static final ObjectMapper metdataObjectMapper = new ObjectMapper() {{ --- End diff -- The goal here was to use only one reference and share between the ring and user-data persistence classes and this was the most logical place to put the reference. I think the problem is that this `ObjectMapper` doesn't really belong in `GossipManager`. An approach I would be happy with is to get rid of the static reference here, and have an instance each for the ring and user-data persistence classes. Let me know what you think. > create gossip-transport-udp module > ---------------------------------- > > Key: GOSSIP-79 > URL: https://issues.apache.org/jira/browse/GOSSIP-79 > Project: Gossip > Issue Type: Improvement > Reporter: Gary Dusbabek > Assignee: Gary Dusbabek > > Create a transport module that houses the UDP transport. > This will probably require some refactoring. It may be prudent to create a > few interfaces that are kept in gossip-core which are then implemented in > gossip-transport-udp. > This probably needs to be a modules > 1 udp-server > 2 udp-client > OtherThings: > GossipManager.build() needs to look at the URI and dynamically load the right > server > GossipCore.send() needs to locate the right client for a URI. > Both of these things probably need a registry. Please dont make it a static > singleton thing ! :) -- This message was sent by Atlassian JIRA (v6.3.15#6346)