[
https://issues.apache.org/jira/browse/GOSSIP-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974577#comment-15974577
]
ASF GitHub Bot commented on GOSSIP-79:
--------------------------------------
Github user gdusbabek commented on a diff in the pull request:
https://github.com/apache/incubator-gossip/pull/47#discussion_r112192398
--- Diff: gossip-base/src/main/java/org/apache/gossip/GossipSettings.java
---
@@ -45,6 +45,9 @@
private String activeGossipClass =
"org.apache.gossip.manager.SimpleActiveGossipper";
+ private String transportManagerClass =
"org.apache.gossip.transport.UdpTransportManager";
--- End diff --
`UdpTransportManager` will not be available once it's in a different
module.
Ideally, Gossip will not work unless a transport manager is specified, but
I was going for non-breaking at this point.
> create gossip-transport-udp module
> ----------------------------------
>
> Key: GOSSIP-79
> URL: https://issues.apache.org/jira/browse/GOSSIP-79
> Project: Gossip
> Issue Type: Improvement
> Reporter: Gary Dusbabek
> Assignee: Gary Dusbabek
>
> Create a transport module that houses the UDP transport.
> This will probably require some refactoring. It may be prudent to create a
> few interfaces that are kept in gossip-core which are then implemented in
> gossip-transport-udp.
> This probably needs to be a modules
> 1 udp-server
> 2 udp-client
> OtherThings:
> GossipManager.build() needs to look at the URI and dynamically load the right
> server
> GossipCore.send() needs to locate the right client for a URI.
> Both of these things probably need a registry. Please dont make it a static
> singleton thing ! :)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
