By the way, it would be preferable if you could give us details and the reason for the problem that you pointed out, since you are the specialist in this field. We may take a lot of time troubleshooting compared to what you did.
On 2026/06/20 05:00:18 Yu Qi wrote: > Yeah. `JsonArrowSchemaConverter` is a utility class that does not refer to > the `lance-namespace` and is specified for Gravitino. I haven't found any > concrete clue that can verify your claim. > > Please correct me and provide details if I'm wrong. Thanks. > > On 2026/06/20 00:13:39 Justin Mclean wrote: > > Hi, > > > > -1 (binding) from me. > > > > I checked: > > - signatures and hashes are fine > > - LICENSE is missing some 3rd party code (see below) and may have incorrect > > headers > > - all files have ASF headers where needed > > - no unexpected binary files > > > > A spot check of files added since the last release shows that several have > > incorrect ASF headers and seem to be be 3rd party code: > > - FederatedCatalogWrapper.java [1] seems to contain code from Apache Polaris > > - JsonArrowSchemaConverter.java [2] seems to contain code from lancedb > > lance-namespace > > - PaimonViewTestCatalogHelper.java[3] seems to contain code from Apache > > Paimon > > > > These may also be an issue, but the code is fairly generic: > > - PageUtil.java[4] seems to contain code from lance-namespace-hive2 > > - GravitinoGlueCredentialsProvider.java[5] seems to contain code from > > Apache Doris > > > > I did not perform an exhaustive check, so there may be other 3rd-party > > files incorrectly labeled in the release. > > > > Also, I think the license of "Bouncy Castle” may also be incorrect. (As an > > aside, I met the creator of Bouncy Castle a couple of days ago), it has an > > MIT-style license. > > > > Kind Regards, > > Justin > > > > 1. > > iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/FederatedCatalogWrapper.java > > 2. > > lance/lance-common/src/main/java/org/apache/gravitino/lance/common/ops/gravitino/JsonArrowSchemaConverter.java > > 3. > > catalogs/catalog-lakehouse-paimon/src/test/java/org/apache/gravitino/catalog/lakehouse/paimon/utils/PaimonViewTestCatalogHelper.java > > 4. > > lance/lance-common/src/main/java/org/apache/gravitino/lance/common/ops/gravitino/PageUtil.java > > 5. > > catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GravitinoGlueCredentialsProvider.java > > > > >
