Hi,
Thanks for the quick turnaround and the PR. The Bouncy Castle, Iceberg (agreed,
CatalogHandlers is the right origin rather than Polaris), Paimon, and PageUtil
fixes all look right.
On the other two:
JsonArrowSchemaConverter. The match is not to the org.lance.namespace.model
POJOs, it is to a converter of the same name and package in lance-namespace.
The pointer is:
• component pkg:maven/com.lancedb/lance-namespace-core (0.0.21 or later)
• file com/lancedb/lance/namespace/util/JsonArrowSchemaConverter.java
• matching regions: local lines 25-54, 79-134, 151-165 against upstream
22-51, 264-319, 253-267
Please diff your class against that file, in particular the Arrow type to type
name mapping, and confirm whether it was adapted, or perhaps someone who
checked in that code can confirm that? Alternatively, perhaps AI has copied
code from other projects here, and if AI is used, the project needs to take
steps to prevent this.
Re GravitinoGlueCredentialsProvider, as I said, this is largely the standard
AwsCredentialsProvider shape, so that’s fine, unless it was derived from AWS's
sample provider, in which case AWS should be credited.
On process: I ran the files through SCANOSS, which is what surfaced these, but
my check was not exhaustive, so it would be worth running it over the whole
tree before the next RC.
More importantly, checking license compliance is a responsibility of the PMC as
a whole, and identifying and attributing third-party or adapted code rests with
the committer who adds it. A clean pass before the next RC saves everyone teh
need to create extra RCs.
Kind regards,
Justin
