Pardon me if i don't understand,
but your patch in vcl creates a new KEY_MOD5 where what you went out to
do was fixing the behaviour of KEY_MOD2. Instead of changing the
independent vcl part so it fits the dependent part you should rather
achieve that KEY_MOD2 ist only sent when it ought to. If this means you
need another internal modifier with the vcl/unx part, fine, but i think
it's a really bad idea to put that into the independent part #ifdef'd
with MACOSX.
Yes there are some instances of #ifdef MACOSX (or UNX for that matter)
already in the independent part, but we should make them less, not more.
Besides KEY_MOD5 does not seem to have any use outside of vcl either.
Worse, KEY_MOD5 is only defined in the MACOSX case of keycodes.hxx. This
is an exported header and should be system neutral like all the others
except sysdata.hxx which is system dependent by definition.
I don't think this patch is a good idea.
Just my 2 cents, pl
eric b wrote:
Hi,
As you probably know, we have keyboard issues on Mac OS X, with X11 : by
default ALT key does not work.
e.g. ( { [ \ | } } € keys are missing (formulas cannot be written !
), and we first used a (bad) workaround, starting X11 with +kb extension.
This extension leads to two bugs : one with caps lock ( see #i58750# ),
a second one when X11 is started before OpenOffice.org
Now, using an old patch, I have adapted it to match with 2.0.x code,
and have created macosxkbd in this purpose.
The code builds fine, all other archs OS are protected (using #ifdef
MACOSX ) and works fine under the 3 Mac OS X
- Panther (10.3.x) PowerPC
- Tiger (10.4.x) PowerPC and Intel
No issue reported by testers ( administrations with a lot of installed
machines), since I included this change in testing build.
mod5 is used because known to not cause issues for e.g. Japanese
(Etsushi Kato confirmed this mod is ok)
This cws is Ready for QA, 2.0.4 deadline is close, and my QA (Tino
Rachui) is maybe on hollidays :-)
Is it possible anyone confirm the changes are ok ?
FYI : cwsname is macosxkbd ; concerned modules are desktop, vcl ;
milestone used for the changes : m174
Of course, this is a temporarly solution : we should complete the
remapping with Apple key only, and differentiate it's behaviour with
CTRL key, but we really need more time, if ever a solution really does
exist.
Last, complete change is not possible if we want to respect 2.0.4 deadline.
Thank's in advance for any help !
Eric Bachard
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
If you give someone a program, you will frustrate them for a day;
if you teach them how to program, you will frustrate them for a lifetime.
-- Author unknown
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
