Hi Philipp,
First, thank you for your expertise !
I have asked here, simply because I was not sure my changes are correct
or not. Now, I have directions to investigate.
Philipp Lohmann - Sun Germany a écrit :
Pardon me if i don't understand,
but your patch in vcl creates a new KEY_MOD5
Yes, a new modifier. I'll explain later.
where what you went out to
do was fixing the behaviour of KEY_MOD2.
Not exactly
Instead of changing the
independent vcl part so it fits the dependent part you should rather
achieve that KEY_MOD2 ist only sent when it ought to. If this means you
need another internal modifier with the vcl/unx part, fine,
As you probably know, on Mac OS X, we don't use the keyboard as
expected. In our case, we use Apple, key, exactly like CTRL key , but
this is a complete workaround: just a logical "OR" between the two keys.
None is satisfied with current behaviour: use Apple key a different way
as described in Aqua Human Interface Guidelines is a non sense for Mac
users, because the Mac OS X feeling is not respected.
This is something very very important. You can believe me.
Whorse : with recent X11 (coming with Mac OS X 10.4.x, aka Tiger),
provided by Apple, ALT key did not work at all.
So a lot of keys are missing ( [ ] ) \ | € ..and all " ALT " use :-/
To change that, we (ssa proposed) first used +kb extension when
launching X11. This last fix was not correct, because it introduced a
new bug #i58750#.
Another simple fix could be use xmodmap. (using a file with correct
remap of Mode_Switch aka ALT, using mod5 )
As summary: none of these fixes were correct, and my cws was a first try
to make things work.
So, what is scheduled ?
1) remap ALT key (very urgent ) : IMHO done in macosxkbd
2) remap Apple key as expected, and respecting Aqua Human Interface
Guidelines : TODO
Waiting a better solution, I decided to
a) use mod5 (this modifier is confirmed without issue)
b) continue to investigate , the time to understand if a complete *Mac
only* solution can be found.
Of course, if modifier 2 is enough, no problem to use it again :-)
but i think
it's a really bad idea to put that into the independent part #ifdef'd
with MACOSX.
I just wanted to protect all other OS's arch's from my changes.
Yes there are some instances of #ifdef MACOSX (or UNX for that matter)
already in the independent part, but we should make them less, not more.
What I perfectly understand.
Besides KEY_MOD5 does not seem to have any use outside of vcl either.
Worse, KEY_MOD5 is only defined in the MACOSX case of keycodes.hxx.
Yes, I did this choice to be sure, it breaks nothing else.
This is an exported header and should be system neutral like all the others
except sysdata.hxx which is system dependent by definition.
I don't think this patch is a good idea.
If you have any suggestion, please do. In fact, the work is not finished.
Anyway, thank you for your opinion.
Regards,
Eric Bachard
--
<ericb at openoffice |dot_ org>
Francophone OpenOffice.org Commmunity developer (Linux PPC / Mac OS X /
X11)
See : <http://fr.openoffice.org>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
