eric b wrote:
Hi Philipp,
I'll ask on [EMAIL PROTECTED] mailing list, for a complete list of expected
Apple key behaviour, and I'll re-contact you when done.
Thank you.
But it does. If it only changed the VCL API, that wouldn't be a
problem, but the numerical KeyCodes go into documents - at least that
was the problem why the original issue 11004 was not integrated. I
hope that mba has a comment on that. By changing the KeyCodes the way
you do you break macros in existing documents on the mac and also by
new documents produced on the mac and read somewhere else.
Just none yet reported such issue.
Not to wonder, this would only begin to appear as soon as that code
entered the Mac version and people began using this. Also it is a
feature not so often used (only scripts based on key input would be
affected). Still breaking existing documents is always a bad idea.
However this issue seems to be true only for the old binary formats as i
understand from Carsten's answer, so we probably do not have a big issue
here.
This is an exported header and should be system neutral like all the
others except sysdata.hxx which is system dependent by definition.
I don't think this patch is a good idea.
If you have any suggestion, please do. In fact, the work is not
finished.
If you need a KEY_MOD5 (why by the way MOD5 ?
Because this mod was adviced by some people who helped us to find a
working solution at the begining, and none reported issue using it (I
was not sure it works with MOD3 ).
So you want to keep the X11 terminology. We then should have KEY_MOD3
and KEY_MOD4 also, but this would mean enlarging the KeyCode since it
currently is a USHORT. Worse, the API definition in offapi is also
"short", so we cannot really extend that bitmask without breaking
compatibility.
the original patch contained a new KEY_MOD3 which would be more
logical), then the #ifdef in keycodes.hxx at least will have to
vanish. It would not be good to litter the whole code beyond vcl with
them.
Sorry, I'm not sure to completely understand. " #ifdef MACOSX ...etc "
are only used at buildtime, not at runtime ?
Yes. But if KEY_MOD5 only exists in MACOSX case, then sfx (or any other
module dependent on vcl) can only develop with KEY_MOD5 in #ifdef MACOSX
also. VCL is an abstraction layer to window toolkits, it hides the
platform dependencies, not exports them. If you want KEY_MOD5 as an
exported vcl API, then do it for all platforms, even if on other
platforms it will not occur for the time being. E.g. as soon as you have
this KEY_MOD5 you want to have it in the configuration dialog, also, to
be able to assign key combinations with that modifier.
Also the matter of document compatibility will have to be addressed;
whether there is such a problem and if yes how to solve it right. I
hope mba or cd has a comment on this.
Thank you to have forwarded the mail.
Waiting for more infos :-)
Carsten thankfully put that matter to rest.
Kind regards, pl
--
If you give someone a program, you will frustrate them for a day;
if you teach them how to program, you will frustrate them for a lifetime.
-- Author unknown
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
