Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/242#discussion_r165833051
--- Diff:
extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java
---
@@ -155,9 +157,10 @@ public AuthenticatedUser authenticateUser(Credentials
credentials)
// This is a response to a previous challenge, authenticate with
that.
else {
try {
+ byte[] stateBytes =
javax.xml.bind.DatatypeConverter.parseHexBinary(request.getParameter(RadiusStateField.PARAMETER_NAME));
--- End diff --
Might not be a bad idea to handle the `IllegalArgumentException` case for
`parseHexBinary()` either, so that the backend generally behaves in a robust
manner regardless of what's thrown at it (safely catches and handles data which
does not match our assumptions rather than exploding).
---
