Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/242#discussion_r165833343
--- Diff:
extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/RadiusConnectionService.java
---
@@ -282,15 +282,15 @@ public RadiusPacket authenticate(String username,
String secret, String state)
* @throws GuacamoleException
* If an error is encountered trying to talk to the RADIUS server.
*/
- public RadiusPacket sendChallengeResponse(String username, String
response, String state)
+ public RadiusPacket sendChallengeResponse(String username, String
response, byte[] state)
throws GuacamoleException {
if (username == null || username.isEmpty()) {
logger.error("Challenge/response to RADIUS requires a
username.");
return null;
}
- if (state == null || state.isEmpty()) {
+ if (state == null || state.length < 1) {
--- End diff --
Okay, should be done in a slightly more acceptable fashion, now.
---
