Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/242#discussion_r165832815
--- Diff:
extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java
---
@@ -97,7 +99,7 @@ private CredentialsInfo getRadiusChallenge(RadiusPacket
challengePacket) {
// We have the required attributes - convert to strings and then
generate the additional login box/field
String replyMsg = replyAttr.toString();
- String radiusState = new String(stateAttr.getValue().getBytes());
+ String radiusState =
javax.xml.bind.DatatypeConverter.printHexBinary(stateAttr.getValue().getBytes());
--- End diff --
Yowza. My knee-jerk reaction was to suggest that you import
`javax.xml.bind.DatatypeConverter`, but I see you've actually already done
that. ;)
This should be switched over to just
`DatatypeConverter.printHexBinary(...)`.
---
