Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/252#discussion_r167409807
  
    --- Diff: 
guacamole-common/src/main/java/org/apache/guacamole/websocket/GuacamoleWebSocketTunnelEndpoint.java
 ---
    @@ -71,11 +71,15 @@
          *
          * @param session The outbound WebSocket connection to close.
          * @param guac_status The status to send.
    +     * @param webSocketCode The numeric WebSocket status to send.
          */
    -    private void closeConnection(Session session, GuacamoleStatus 
guac_status) {
    +    private void closeConnection(Session session, GuacamoleStatus 
guac_status,
    +            Integer webSocketCode) {
     
             try {
    -            CloseCode code = 
CloseReason.CloseCodes.getCloseCode(guac_status.getWebSocketCode());
    +            if (webSocketCode == null)
    --- End diff --
    
    Switched to `int` and the same approach - passing both parameters as an 
`int` and not passing `GuacamoleStatus` at all.


---

Reply via email to