Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/252#discussion_r168080950
  
    --- Diff: 
guacamole-common/src/main/java/org/apache/guacamole/websocket/GuacamoleWebSocketTunnelEndpoint.java
 ---
    @@ -85,6 +92,21 @@ private void closeConnection(Session session, 
GuacamoleStatus guac_status) {
     
         }
     
    +    /**
    +     * Sends the given Guacaomle Status and closes the given
    +     * connection.
    +     *
    +     * @param session
    +     *     The outbound WebSocket connection to close.
    +     *
    +     * @param guac_status
    --- End diff --
    
    Being new/touched code, this should be updated to match current code style 
(`guacStatus` not `guac_status`). The old `guac_status` parameter is a holdover 
from the days where I used C style for everything.


---

Reply via email to