Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/252#discussion_r167409840
  
    --- Diff: 
guacamole-common/src/main/java/org/apache/guacamole/websocket/GuacamoleWebSocketTunnelEndpoint.java
 ---
    @@ -109,15 +113,15 @@ public void onOpen(final Session session, 
EndpointConfig config) {
                 // Get tunnel
                 tunnel = createTunnel(session, config);
                 if (tunnel == null) {
    -                closeConnection(session, 
GuacamoleStatus.RESOURCE_NOT_FOUND);
    +                closeConnection(session, 
GuacamoleStatus.RESOURCE_NOT_FOUND, null);
    --- End diff --
    
    I re-implemented this with just `int` and no overloading, since the only 
reason to pass the `GuacamoleStatus` parameter is to access the 
`getGuacamoleStatusCode()` method.  Let me know how this looks - it doesn't 
feel very elegant, but maybe better than `Integer` and `null` route.


---

Reply via email to